<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Tabs: Conflicts with multiple Formatters per SourceCode"
href="https://bugs.webkit.org/show_bug.cgi?id=144717#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Tabs: Conflicts with multiple Formatters per SourceCode"
href="https://bugs.webkit.org/show_bug.cgi?id=144717">bug 144717</a>
from <span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271128&action=diff" name="attach_271128" title="[PATCH] Proposed Fix">attachment 271128</a> <a href="attachment.cgi?id=271128&action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
[PATCH] Proposed Fix
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271128&action=review">https://bugs.webkit.org/attachment.cgi?id=271128&action=review</a>
<span class="quote">>> Source/WebInspectorUI/UserInterface/Views/ContentView.js:68
>> + static _finalRepresentedObjectForRepresentedObject(representedObject)
>
> The '_final' terminology is confusing to me. Can we call it 'resolved' or 'displayable' or something like that? When reading it as 'finalRepresentedObject' i had the impression that it was being mutated or something.</span >
I like resolved.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/ContentView.js:84
> + else if (representedObject.sourceCode instanceof WebInspector.Script)</span >
No else.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js:423
> + console.assert(!contentView.__tombstoneContentViewContainers || !contentView.__tombstoneContentViewContainers.includes(this));</span >
Why not a symbol?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>