<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sam@webkit.org" title="Sam Weinig <sam@webkit.org>"> <span class="fn">Sam Weinig</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Soft spaces are often tracked in the wrong spot"
href="https://bugs.webkit.org/show_bug.cgi?id=154127">bug 154127</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #271088 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Soft spaces are often tracked in the wrong spot"
href="https://bugs.webkit.org/show_bug.cgi?id=154127#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Soft spaces are often tracked in the wrong spot"
href="https://bugs.webkit.org/show_bug.cgi?id=154127">bug 154127</a>
from <span class="vcard"><a class="email" href="mailto:sam@webkit.org" title="Sam Weinig <sam@webkit.org>"> <span class="fn">Sam Weinig</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271088&action=diff" name="attach_271088" title="Patch">attachment 271088</a> <a href="attachment.cgi?id=271088&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271088&action=review">https://bugs.webkit.org/attachment.cgi?id=271088&action=review</a>
Please do the refactor we discussed so we don't have the duplicated code. Also, please file a follow up bug to add the test infrastructure for testing this.
<span class="quote">> Source/WebKit2/UIProcess/WebPageProxy.cpp:5819
> + process().send(Messages::WebPage::InsertTextAsync(text, replacementRange, registerUndoGroup, (uint32_t)editingRangeIsRelativeTo), m_pageID);</span >
static_cast please.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4334
> + RefPtr<Range> replacementRange = rangeFromEditingRange(frame, replacementEditingRange, (EditingRangeIsRelativeTo)editingRangeIsRelativeTo);</span >
static_cast</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>