<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [cmake] Consolidate CMake code related to image decoders."
href="https://bugs.webkit.org/show_bug.cgi?id=154074#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [cmake] Consolidate CMake code related to image decoders."
href="https://bugs.webkit.org/show_bug.cgi?id=154074">bug 154074</a>
from <span class="vcard"><a class="email" href="mailto:annulen@yandex.ru" title="Konstantin Tokarev <annulen@yandex.ru>"> <span class="fn">Konstantin Tokarev</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270993&action=diff" name="attach_270993" title="Patch">attachment 270993</a> <a href="attachment.cgi?id=270993&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270993&action=review">https://bugs.webkit.org/attachment.cgi?id=270993&action=review</a>
<span class="quote">>>> Source/WebCore/ImageDecoders.cmake:29
>>> +if (JPEG_FOUND)
>>
>> I think these should remain unconditional. We should have a hard failure if these aren't found.
>
> WinCairo does not use find_package for libjpeg and libpng, therefore repspective variables are empty. I thought it is not a good practice to append empty variables to the lists.</span >
BTW, hard failure is guaranteed by REQUIRED flag, set by ports in Options*.cmake when find_package is invoked.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>