<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Using 'super' in arrow function that declared out of the class should lead to Syntax error"
href="https://bugs.webkit.org/show_bug.cgi?id=150893#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Using 'super' in arrow function that declared out of the class should lead to Syntax error"
href="https://bugs.webkit.org/show_bug.cgi?id=150893">bug 150893</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270654&action=diff" name="attach_270654" title="Patch">attachment 270654</a> <a href="attachment.cgi?id=270654&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270654&action=review">https://bugs.webkit.org/attachment.cgi?id=270654&action=review</a>
<span class="quote">> Source/JavaScriptCore/ChangeLog:20
> + Invoking super()/super in two or more evals will be part of the issue <a class="bz_bug_link
bz_status_NEW "
title="NEW - Invoking super()/super inside of the double eval should not lead to SyntaxError"
href="show_bug.cgi?id=153864">https://bugs.webkit.org/show_bug.cgi?id=153864</a></span >
what kind of error should this be if it's not a SyntaxError?
<span class="quote">> Source/JavaScriptCore/bytecode/EvalCodeCache.h:70
> + wrappedCodeBlockDerivedContextType = superBinding == SuperBinding::Needed
> + ? DerivedContextType::DerivedMethodContext
> + : derivedContextType;</span >
style: make this one line or add "{}" to the else statement.
<span class="quote">> Source/JavaScriptCore/bytecode/ExecutableInfo.h:67
> + DerivedContextType wrappedCodeBlocContextType() const { return static_cast<DerivedContextType>(m_wrappedCodeBlocContextType); }</span >
typo:
wrappedCodeBlocContextType => wrappedCodeBlockContextType
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:2070
> + if (!m_lexer->isReparsingFunction()) {</span >
Is this needed or just an optimization?
<span class="quote">> Source/JavaScriptCore/parser/Parser.h:881
> + // Find the closest not 'arrow function' function scope.</span >
comment not needed.
<span class="quote">> Source/JavaScriptCore/tests/stress/arrowfunction-lexical-bind-superproperty.js:-131
> - getParentValueWithError() {
> - var f = function () {
> - return () => super.getValue();
> - };
> - return f();
> - }</span >
you could keep this if you turned this into an "return eval(blah)"</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>