<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Network cache: old pages returned by disk cache on history navigation after session is restored"
href="https://bugs.webkit.org/show_bug.cgi?id=153230#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Network cache: old pages returned by disk cache on history navigation after session is restored"
href="https://bugs.webkit.org/show_bug.cgi?id=153230">bug 153230</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270655&action=diff" name="attach_270655" title="Patch">attachment 270655</a> <a href="attachment.cgi?id=270655&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270655&action=review">https://bugs.webkit.org/attachment.cgi?id=270655&action=review</a>
What I would suggest would be:
1. Revert <a href="http://trac.webkit.org/changeset/181815">http://trac.webkit.org/changeset/181815</a> so that our API has a "allowStaleContent" parameter again (which I find clearer that the approach in this patch)
2. Add a setting to decide in restoreSession() if we want to allow stale content or not.
3. Set this setting to True on iOS and False elsewhere.
<span class="quote">> Source/WebCore/history/HistoryItem.h:206
> + void setShouldRevalidateInDiskCacheOnly(bool revalidateInDiskCache) { m_shouldRevalidateInDiskCacheOnly = revalidateInDiskCache; }</span >
I think the naming here is not very clear. Also, I am not sure why we need to add a data member to HistoryItem.
<span class="quote">> Source/WebKit2/WebProcess/WebCoreSupport/SessionStateConversion.h:41
> + APIRequest</span >
I personally don't find this to be clear.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2187
> + restoreSessionInternal(itemStates, SessionRestoreMode::APIRequest);</span >
I think allowing stale content on session restore should be based on a setting. I know that we want to keep allowing stale content on iOS for example.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>