<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Format revisions for display according to repository type"
href="https://bugs.webkit.org/show_bug.cgi?id=153818">bug 153818</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #270610 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Format revisions for display according to repository type"
href="https://bugs.webkit.org/show_bug.cgi?id=153818#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Format revisions for display according to repository type"
href="https://bugs.webkit.org/show_bug.cgi?id=153818">bug 153818</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270610&action=diff" name="attach_270610" title="Patch">attachment 270610</a> <a href="attachment.cgi?id=270610&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270610&action=review">https://bugs.webkit.org/attachment.cgi?id=270610&action=review</a>
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:127
> - linkElement.textContent = "r" + commit.revisionNumber;
> + linkElement.textContent = this._formatRevisionForDisplay(commit.revisionNumber, branch.repository);</span >
Is "revision number" the right terminology for git?
Just curious, no need to update all the naming for this patch even if it's not quite right.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:339
> + _formatRevisionForDisplay: function (revision, repository)</span >
Please remove the space after "function".
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:347
> + if (repository.isSVN)
> + return "r" + revision;
> + else if (repository.isGit)
> + // Truncating for display. Git traditionally uses seven characters for a short hash.
> + return revision.substr(0, 7);
> + else
> + console.assert(false, "Should not get here; " + repository.name + " did not specify a known VCS type.");</span >
WebKit style is to not use else after return. Here is how I would write this:
console.assert(repository.isSVN || repository.isGit);
if (repository.isSVN)
return "r" + revision;
// Truncating for display. Git traditionally uses seven characters for a short hash.
return revision.substr(0, 7);</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>