<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Reduce IPC traffic due to view state changes"
href="https://bugs.webkit.org/show_bug.cgi?id=153745#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Reduce IPC traffic due to view state changes"
href="https://bugs.webkit.org/show_bug.cgi?id=153745">bug 153745</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153745#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=270390&action=diff" name="attach_270390" title="Patch">attachment 270390</a> <a href="attachment.cgi?id=270390&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=270390&action=review">https://bugs.webkit.org/attachment.cgi?id=270390&action=review</a>
>
> Nice patch, although I think it doesn't really work as is (see my comment
> about the mask)</span >
Thanks for the review!
<span class="quote">> > Source/WebKit2/ChangeLog:27
> > + WebPageProxy::viewStateDidChange() and resret the flags that need
>
> resret -> reset</span >
Oops.
<span class="quote">> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:316
> > + g_signal_connect(priv->toplevelOnScreenWindow, "window-state-event", G_CALLBACK(toplevelWindowStateEvent), webViewBase);
>
> According to the docs you should enable GDK_STRUCTURE_MASK something that
> you are not doing. You should also remove the GDK_VISIBILITY_NOTIFY_MASK.</span >
But then it says "GDK will enable this mask automatically for all new windows." Also note that this is not a signal of the web view, but the toplevel window, and GtkWindos adds the GDK_STRUCTURE_MASK unconditionally in realize method.
<span class="quote">> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1385
> > + unsigned flagsToUpdate = ViewState::IsFocused;
>
> We could use ViewState::Flags here for consistency with the rest of the code
> (even though it's an unsigned anyway).</span >
OK.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>