<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Add support for windowless NPAPI plugins with no UI in non X11 platforms"
href="https://bugs.webkit.org/show_bug.cgi?id=151992#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Add support for windowless NPAPI plugins with no UI in non X11 platforms"
href="https://bugs.webkit.org/show_bug.cgi?id=151992">bug 151992</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151992#c10">comment #10</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=270480&action=diff" name="attach_270480" title="Updated patch">attachment 270480</a> <a href="attachment.cgi?id=270480&action=edit" title="Updated patch">[details]</a></span>
> Updated patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=270480&action=review">https://bugs.webkit.org/attachment.cgi?id=270480&action=review</a>
>
> While I’m not a platform expert I think I can review.</span >
Thanks!
<span class="quote">> > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:534
> > + const auto& display = WebCore::PlatformDisplay::sharedDisplay();
>
> I don’t think the const here is needed or helpful.</span >
Ok, removed.
<span class="quote">> > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:537
> > + *reinterpret_cast<Display**>(value) = downcast<PlatformDisplayX11>(display).native();
>
> Strange that the WebCore prefix is not needed here but is needed on the line
> above.</span >
It's not needed, there's a using namespace in this file.
<span class="quote">> > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:56
> > class NetscapePluginStream;
> > -
> > +#if PLUGIN_ARCHITECTURE(X11)
> > +class NetscapePluginUnix;
> > +#endif
> > class NetscapePlugin : public Plugin {
>
> Please don’t delete the blank line here that separates the forward
> declarations from the class definition. Not clear that we need to put #if
> around a forward declaration. If we do, then please put it in a separate
> paragraph with spaces above and below the #if/#endif</span >
I don't think we need ifdefs.
<span class="quote">> > Source/WebKit2/WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.h:31
> > +#include <WebCore/GraphicsContext.h>
>
> I think we could use forward declarations for GraphicsContext and IntRect in
> this file rather than including the header, which is typically better.</span >
Ok.
<span class="quote">> > Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:31
> > +#if PLUGIN_ARCHITECTURE(X11)
> > +#include "NetscapePluginUnix.h"
>
> We normally put a blank line here between the #if and the #include.</span >
Ok.
<span class="quote">> > Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:38
> > +class NetscapePluginX11 final: public NetscapePluginUnix {
>
> We normally put a space after final before ":".</span >
OK.
<span class="quote">> > Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:46
> > +private:
>
> We normally put a blank line here before private.</span >
Ok.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>