<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Pending API request URL no set when loading Alternate HTML or plain text"
href="https://bugs.webkit.org/show_bug.cgi?id=136916#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Pending API request URL no set when loading Alternate HTML or plain text"
href="https://bugs.webkit.org/show_bug.cgi?id=136916">bug 136916</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=136916#c12">comment #12</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=243974&action=diff" name="attach_243974" title="Now also including the xcode file changes">attachment 243974</a> <a href="attachment.cgi?id=243974&action=edit" title="Now also including the xcode file changes">[details]</a></span>
> Now also including the xcode file changes
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=243974&action=review">https://bugs.webkit.org/attachment.cgi?id=243974&action=review</a>
>
> I’m saying review+ but I’d still like to understand if Anders agrees about
> this use of "about:blank".
>
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:860
> > + auto transaction = m_pageLoadState.transaction();
> > + m_pageLoadState.setPendingAPIRequestURL(transaction, ASCIILiteral("about:blank"));
>
> I think it’s a little peculiar to actually set the URL to about::blank here.
> Do we agree that explicitly giving it this particular URL makes sense? Does
> WebKit already treat this as if it came from that URL in other ways or is
> that a new concept we are introducing? If WebKit does already use this URL
> then why are we having to inject it specifically here?
>
> I think this would read better without the local variable even though the
> other function does have it in a local variable since it uses it twice. I
> think blankURL().string() is better than ASCIILiteral("about:blank").
>
> m_pageLoadState.setPendingAPIRequestURL(m_pageLoadState.transaction(),
> blankURL().string());</span >
The local variable is not because it's reused, but because we want the transaction to be finished when the function goes out of scope, the transaction destructor is the one committing the changes to the page load state.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>