<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Add support for windowless NPAPI plugins with no UI in non X11 platforms"
href="https://bugs.webkit.org/show_bug.cgi?id=151992#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Add support for windowless NPAPI plugins with no UI in non X11 platforms"
href="https://bugs.webkit.org/show_bug.cgi?id=151992">bug 151992</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=266898&action=diff" name="attach_266898" title="Try to fix EFL build">attachment 266898</a> <a href="attachment.cgi?id=266898&action=edit" title="Try to fix EFL build">[details]</a></span>
Try to fix EFL build
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=266898&action=review">https://bugs.webkit.org/attachment.cgi?id=266898&action=review</a>
<span class="quote">>> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:275
>> + ASSERT(m_plugin.isWindowed());
>
> Won't this be called with windowless? It looks like the only criteria for platformPaint() to call this one is whether it's running under X, and I'd expect windowed plugins to do their own painting?</span >
You are right, I forgot to return early in NetscapePlugin::platformPaint() like I do in other windowless only methods. Good catch!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>