<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r195463): [GTK] accessibility/roles-computedRoleString.html and accessibility/roles-exposed.html failing"
href="https://bugs.webkit.org/show_bug.cgi?id=153696#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r195463): [GTK] accessibility/roles-computedRoleString.html and accessibility/roles-exposed.html failing"
href="https://bugs.webkit.org/show_bug.cgi?id=153696">bug 153696</a>
from <span class="vcard"><a class="email" href="mailto:mario@webkit.org" title="Mario Sanchez Prada <mario@webkit.org>"> <span class="fn">Mario Sanchez Prada</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153696#c6">comment #6</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=270382&action=diff" name="attach_270382" title="Patch proposal">attachment 270382</a> <a href="attachment.cgi?id=270382&action=edit" title="Patch proposal">[details]</a></span>
> Patch proposal
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=270382&action=review">https://bugs.webkit.org/attachment.cgi?id=270382&action=review</a>
>
> > LayoutTests/platform/gtk/accessibility/roles-computedRoleString-expected.txt:51
> > +FAIL: pre -> . Expected: group.
>
> It's too confusing to have FAIL print in our expected results; we should do
> this less often. Can you try reworking the test to avoid this?</span >
I spoke to Joanie over IRC and she agrees that the current situation is broken in ATK, but not only due to <pre> elements being exposed as ATK_ROLE_PANEL, but also due to inline elements that should be exposed as ATK_ROLE_STATIC being also exposed as ATK_ROLE_PANEL, because now they are all GroupRoles internally, plus a specific subrole that is not used in the ATK role.
So, we think that restoring the old behaviour is the way to go, and probably making the code Mac-specific is the way to go, since those changes do only make sense in a context where role+subrole are used.
Now about the test expectation: Joanie agrees on whatever the computed role string is printed out is not really relevant as long as that gets exposed as an ATK_ROLE_SECTION in the ATK world, so perhaps the right thing to do here is to adapt the WebKitGTK's WKTR so that it prints the right thing in there (after all, it was printing a '.' before).
If nobody has any objection, I'll probably work into a new patch in that direction (keeping isStyleFormatGroup() Mac-specific + adapting WKTR) changes tomorrow morning.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>