<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add code to parse the git branches out of the Trac RSS feed"
href="https://bugs.webkit.org/show_bug.cgi?id=153624">bug 153624</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #270426 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add code to parse the git branches out of the Trac RSS feed"
href="https://bugs.webkit.org/show_bug.cgi?id=153624#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add code to parse the git branches out of the Trac RSS feed"
href="https://bugs.webkit.org/show_bug.cgi?id=153624">bug 153624</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270426&action=diff" name="attach_270426" title="Patch">attachment 270426</a> <a href="attachment.cgi?id=270426&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270426&action=review">https://bugs.webkit.org/attachment.cgi?id=270426&action=review</a>
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:169
> + var gitBranches = doc.evaluate("./branches", commitElement, null, XPathResult.STRING_TYPE).stringValue;</span >
I am assuming that doc.evaluate("./branches", commitElement, null, XPathResult.STRING_TYPE) always returns an object. We should add a test case for an entry that does not have <branches>.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:54
> + client.open('GET', 'test-fixture-git-trac-rss.xml', false);</span >
Nit: We use single quoted string literals here and double quoted string literals below. We should pick one quoting style for string literals and stick with it.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:58
> + client.onreadystatechange = function () {
> + if (client.readyState === client.DONE)
> + this.trac._loaded(client.responseXML);
> + }.bind(this);</span >
Nit: We're underutilizing the the onreadystatechange listener. Since we only care if the load completed successfully, we could register a onload listener. See <<a href="https://xhr.spec.whatwg.org/#event-handlers">https://xhr.spec.whatwg.org/#event-handlers</a>> for a list of the event handlers that can be registered on XMLHttpRequest.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>