<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [webkitdirs] Clarify logic behind is{PortName} functions."
href="https://bugs.webkit.org/show_bug.cgi?id=153554">bug 153554</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #270213 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [webkitdirs] Clarify logic behind is{PortName} functions."
href="https://bugs.webkit.org/show_bug.cgi?id=153554#c20">Comment # 20</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [webkitdirs] Clarify logic behind is{PortName} functions."
href="https://bugs.webkit.org/show_bug.cgi?id=153554">bug 153554</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270213&action=diff" name="attach_270213" title="Patch">attachment 270213</a> <a href="attachment.cgi?id=270213&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270213&action=review">https://bugs.webkit.org/attachment.cgi?id=270213&action=review</a>
<span class="quote">>> Tools/Scripts/build-jsc:86
>> + die "Please choose which WebKit port to build";
>
> It would be good to list available ports and show how to select the port. For example:
>
> "Please specify which WebKit port to build with --efl or --gtk."
>
> This only matters for Linux, since other platforms have default ports.
>
> This could could be shared between build-jsc, build-webkit, and also run-minibrowser (which currently prints an extraordinarily confusing warning that the platform is not supported unless you magically know to pass --efl or --gtk).</span >
It’s slightly more idiomatic perl to write:
die "Please specify which WebKit port to build with --efl or --gtk." if $isUnknownPort();
<span class="quote">> Tools/Scripts/build-webkit:142
> +if (isUnknownPort()) {
> + die "Please choose which WebKit port to build";
> +}</span >
Ditto.
Quite annoying that this needs to be repeated in two separate scripts. Please find a way to avoid that.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>