<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [webkitdirs] Clarify logic behind is{PortName} functions."
href="https://bugs.webkit.org/show_bug.cgi?id=153554#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [webkitdirs] Clarify logic behind is{PortName} functions."
href="https://bugs.webkit.org/show_bug.cgi?id=153554">bug 153554</a>
from <span class="vcard"><a class="email" href="mailto:annulen@yandex.ru" title="Konstantin Tokarev <annulen@yandex.ru>"> <span class="fn">Konstantin Tokarev</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270031&action=diff" name="attach_270031" title="Patch">attachment 270031</a> <a href="attachment.cgi?id=270031&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270031&action=review">https://bugs.webkit.org/attachment.cgi?id=270031&action=review</a>
<span class="quote">>> Tools/ChangeLog:22
>> + (buildCMakeProjectOrExit): Deleted.
>
> In a good quality change log, we make comments saying what we did to each function.</span >
Thanks, will fix it.
<span class="quote">>>> Tools/Scripts/webkitdirs.pm:103
>>> + IOS => "IOS",
>>
>> This should probably be iOS.
>
> Yes, it should.</span >
I know what is the right capitalization of "iOS", however I capitilized "I" here because other port names start with capital and these names are often used in the middle of word, e.g., isIOSWebKit(), and I guess there will be PlatformIOS.cmake when/if iOS port migrates to cmake.
However we can just ucfirst portName() where capitalization is needed.
<span class="quote">>> Tools/Scripts/webkitdirs.pm:1060
>> + $portName = "AppleWin";
>
> Don’t we want to use the constant here?</span >
Yes, we do.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>