<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix bugs caused by incorrect usage of "branch" vs. "branchName"."
href="https://bugs.webkit.org/show_bug.cgi?id=153330#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix bugs caused by incorrect usage of "branch" vs. "branchName"."
href="https://bugs.webkit.org/show_bug.cgi?id=153330">bug 153330</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269586&action=diff" name="attach_269586" title="Patch">attachment 269586</a> <a href="attachment.cgi?id=269586&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269586&action=review">https://bugs.webkit.org/attachment.cgi?id=269586&action=review</a>
<span class="quote">>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:113
>> + _popoverLinesForCommitRange: function(trac, branch, firstRevisionNumber, lastRevisionNumber)
>
> I'm assuming you plan to make more use of the branch object in a subsequent patch than to get the branch name. Currently this function only makes use of the branch name.</span >
That's correct. I do have a forthcoming patch that will make use of properties other than the branch name.
<span class="quote">>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:115
>> + var branch = this.trunkBranch;
>
> This variable is used exactly once and I do not feel that its name makes the purpose of this variable any more understandable than its values. I suggest that we inline the value of this variable into the line below (line 116) and remove this variable.</span >
Will do.
<span class="quote">>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:129
>> + var branch = this.trunkBranch;
>
> By a similar argument as above, I suggest inlining the value of this variable where its referenced and remove this variable.</span >
Will do.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>