<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [mips] don't save to a callee saved register too early"
href="https://bugs.webkit.org/show_bug.cgi?id=153463#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [mips] don't save to a callee saved register too early"
href="https://bugs.webkit.org/show_bug.cgi?id=153463">bug 153463</a>
from <span class="vcard"><a class="email" href="mailto:jbriance@cisco.com" title="Julien Brianceau <jbriance@cisco.com>"> <span class="fn">Julien Brianceau</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269812&action=diff" name="attach_269812" title="Patch">attachment 269812</a> <a href="attachment.cgi?id=269812&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269812&action=review">https://bugs.webkit.org/attachment.cgi?id=269812&action=review</a>
<span class="quote">> Source/JavaScriptCore/offlineasm/mips.rb:562
> + preList << Instruction.new(operand.codeOrigin, "move", [MIPS_GP_REG, MIPS_GPSAVE_REG])</span >
I'm not a huge fan of this. Instead, can you add something like ' emit "move $s4, $gp" ' at the end of the pushCalleeSaves macro ?
And also take the opportunity to set CalleeSaveRegisterCount to 1 for MIPS and just save/restore $s4 register instead of the $s0-$s4 range.
It seems to work fine on my mips board and slightly reduces the number of generated opcodes in LLInt.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>