<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Crash in AccessibilityTableColumn::headerObject"
href="https://bugs.webkit.org/show_bug.cgi?id=153553#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Crash in AccessibilityTableColumn::headerObject"
href="https://bugs.webkit.org/show_bug.cgi?id=153553">bug 153553</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270016&action=diff" name="attach_270016" title="patch">attachment 270016</a> <a href="attachment.cgi?id=270016&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270016&action=review">https://bugs.webkit.org/attachment.cgi?id=270016&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:12
> + function calls elementRect() for each child cell and that sometimes cause </span >
sometimes "causes"
<span class="quote">> Source/WebCore/accessibility/AccessibilityTable.cpp:506
> + AccessibilityChildrenVector columnsCopy = m_columns;</span >
bad spacing.
<span class="quote">> Source/WebCore/accessibility/AccessibilityTable.cpp:522
> + AccessibilityChildrenVector rowsCopy = m_rows;</span >
bad spacing
<span class="quote">> Source/WebCore/accessibility/AccessibilityTableColumn.cpp:66
> + // This was calculated and cached in addChildren() previously, however sometimes elementRect()</span >
change comment to something like
"This used to be cached during the call to addChildren(), but calling elementRect() can invalidate elements, so its better to ask for this on demand"
<span class="quote">> Source/WebCore/accessibility/AccessibilityTableColumn.cpp:71
> + for (const auto& cell : m_children)</span >
should we make a copy of m_children here in case it invalidates something</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>