<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [webkitdirs] Clarify logic behind is{PortName} functions."
href="https://bugs.webkit.org/show_bug.cgi?id=153554">bug 153554</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #270031 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [webkitdirs] Clarify logic behind is{PortName} functions."
href="https://bugs.webkit.org/show_bug.cgi?id=153554#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [webkitdirs] Clarify logic behind is{PortName} functions."
href="https://bugs.webkit.org/show_bug.cgi?id=153554">bug 153554</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270031&action=diff" name="attach_270031" title="Patch">attachment 270031</a> <a href="attachment.cgi?id=270031&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270031&action=review">https://bugs.webkit.org/attachment.cgi?id=270031&action=review</a>
<span class="quote">> Tools/ChangeLog:22
> + * Scripts/webkitdirs.pm:
> + (determinePortName):
> + (portName):
> + (isEfl):
> + (isGtk):
> + (isWinCairo):
> + (isAppleMacWebKit):
> + (isAppleWinWebKit):
> + (isIOSWebKit):
> + (cmakeBasedPortName):
> + (checkForArgumentAndRemoveFromArrayRef): Deleted.
> + (isX86_64): Deleted.
> + (isCrossCompilation): Deleted.
> + (createiOSSimulatorDevice): Deleted.
> + (buildCMakeProjectOrExit): Deleted.</span >
In a good quality change log, we make comments saying what we did to each function.
<span class="quote">>> Tools/Scripts/webkitdirs.pm:103
>> + IOS => "IOS",
>
> This should probably be iOS.</span >
Yes, it should.
<span class="quote">> Tools/Scripts/webkitdirs.pm:1060
> + $portName = "AppleWin";</span >
Don’t we want to use the constant here?
<span class="quote">> Tools/Scripts/webkitdirs.pm:1064
> + $portName = "IOS";</span >
Don’t we want to use the constant here?
<span class="quote">> Tools/Scripts/webkitdirs.pm:1066
> + $portName = "Mac";</span >
Don’t we want to use the constant here?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>