<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Add a boundary value to AXTextStateChangeType"
href="https://bugs.webkit.org/show_bug.cgi?id=153085#c33">Comment # 33</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Add a boundary value to AXTextStateChangeType"
href="https://bugs.webkit.org/show_bug.cgi?id=153085">bug 153085</a>
from <span class="vcard"><a class="email" href="mailto:d_russell@apple.com" title="Doug Russell <d_russell@apple.com>"> <span class="fn">Doug Russell</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153085#c32">comment #32</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=269085&action=diff" name="attach_269085" title="Patch">attachment 269085</a> <a href="attachment.cgi?id=269085&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=269085&action=review">https://bugs.webkit.org/attachment.cgi?id=269085&action=review</a>
>
> >>> Source/WebCore/editing/VisiblePosition.h:125
> >>> + bool m_isBoundary = false;
> >>
> >> I think it’s dangerous that now we have a type of VisiblePosition that won’t survive a round trop if broken into position and affinity and then made into a VIsiblePosition again. Do we have other options here rather than adding this state to VisiblePosition?
> >
> > We could thread error state through the modifyMovingX logic to return why the VisiblePosition it's returning is NULL. It would mean touching a lot more code though.
>
> One way to do it would be to add a new type that’s either a VisiblePosition
> or a boundary, rather than adding it to the original VisiblePosition type.
> You would need to touch more code, but just to change the type from
> VisiblePosition to the new type. Even though it makes the patch bigger, I
> think that would likely be better than introducing this concept into all
> other code using VisiblePosition for any other purpose. Could start as
> simply as a struct with a boolean and a VisiblePosition in it.</span >
My latest patch threads a bool * through all the relevant logic. If this works for you I'm happy with it, but I could take the above approach if that's preferable.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>