<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Style resolver initialization cleanups"
href="https://bugs.webkit.org/show_bug.cgi?id=153356">bug 153356</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #269577 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Style resolver initialization cleanups"
href="https://bugs.webkit.org/show_bug.cgi?id=153356#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Style resolver initialization cleanups"
href="https://bugs.webkit.org/show_bug.cgi?id=153356">bug 153356</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269577&action=diff" name="attach_269577" title="patch">attachment 269577</a> <a href="attachment.cgi?id=269577&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269577&action=review">https://bugs.webkit.org/attachment.cgi?id=269577&action=review</a>
<span class="quote">> Source/WebCore/css/StyleResolver.h:453
> - EInsideLink m_elementLinkState;
> + EInsideLink m_elementLinkState { NotInsideLink };
>
> - bool m_elementAffectedByClassRules;
> + bool m_elementAffectedByClassRules { false };
>
> - bool m_applyPropertyToRegularStyle;
> - bool m_applyPropertyToVisitedLinkStyle;
> + bool m_applyPropertyToRegularStyle { true };
> + bool m_applyPropertyToVisitedLinkStyle { false };
>
> PendingImagePropertyMap m_pendingImageProperties;
>
> Vector<RefPtr<ReferenceFilterOperation>> m_filtersWithPendingSVGDocuments;
>
> - bool m_fontDirty;
> - bool m_fontSizeHasViewportUnits;
> + bool m_fontDirty { false };
> + bool m_fontSizeHasViewportUnits { false };
>
> - bool m_hasUAAppearance;
> + bool m_hasUAAppearance { false };
> BorderData m_borderData;
> - FillLayer m_backgroundData;
> + FillLayer m_backgroundData { BackgroundFillLayer };
> Color m_backgroundColor;</span >
Would be nice to pack all the bools and small enums together to save space.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>