<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor compareIterations to remove duplicate code."
href="https://bugs.webkit.org/show_bug.cgi?id=152913">bug 152913</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #268981 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor compareIterations to remove duplicate code."
href="https://bugs.webkit.org/show_bug.cgi?id=152913#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor compareIterations to remove duplicate code."
href="https://bugs.webkit.org/show_bug.cgi?id=152913">bug 152913</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=268981&action=diff" name="attach_268981" title="Patch">attachment 268981</a> <a href="attachment.cgi?id=268981&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=268981&action=review">https://bugs.webkit.org/attachment.cgi?id=268981&action=review</a>
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:48
> + queue = new MockBuildbotQueue();</span >
This is error prone. Specifically, it is error prone to pass module state using global variables. From looking at the examples for setup()/tearDown() on <<a href="http://qunitjs.com/upgrade-guide-2.x/">http://qunitjs.com/upgrade-guide-2.x/</a>> and beforeEach()/afterEach() on <<a href="http://api.qunitjs.com/QUnit.module/">http://api.qunitjs.com/QUnit.module/</a>> the preferred way to share such state is by modifying |this|.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>