<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor compareIterations to remove duplicate code."
href="https://bugs.webkit.org/show_bug.cgi?id=152913#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor compareIterations to remove duplicate code."
href="https://bugs.webkit.org/show_bug.cgi?id=152913">bug 152913</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=152913#c7">comment #7</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=268981&action=diff" name="attach_268981" title="Patch">attachment 268981</a> <a href="attachment.cgi?id=268981&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=268981&action=review">https://bugs.webkit.org/attachment.cgi?id=268981&action=review</a>
>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:65
> > + iteration1.revision = { "openSource": 42 };
>
> I suggest that we instantiate local BuildbotIterations in each test
> function, including this one, instead of modifying the "global" iteration
> instances. Shared objects between tests should be immutable and/or conveyed
> to be immutable. The benefit of using this approach and only sharing
> immutable data between tests is that it makes it straightforward to verify
> correctness.</span >
I addressed in the latest patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>