<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Add a boundary value to AXTextStateChangeType"
href="https://bugs.webkit.org/show_bug.cgi?id=153085#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Add a boundary value to AXTextStateChangeType"
href="https://bugs.webkit.org/show_bug.cgi?id=153085">bug 153085</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269010&action=diff" name="attach_269010" title="Patch">attachment 269010</a> <a href="attachment.cgi?id=269010&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269010&action=review">https://bugs.webkit.org/attachment.cgi?id=269010&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:9
> + an editable elements boundaries.</span >
elements -> element's
<span class="quote">> Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:385
> + [userInfo setObject:[NSNumber numberWithBool:intent.selection.focusChange] forKey:NSAccessibilityTextSelectionChangedFocus];</span >
@(intent.selectin.focusChange)
<span class="quote">> Source/WebCore/editing/FrameSelection.cpp:1110
> + // FIXME: BIDI</span >
do you have a WK bug to reference
<span class="quote">> Source/WebCore/editing/FrameSelection.cpp:1164
> + return (AXTextSelection) { intentDirection, intentGranularity, false };</span >
is the cast necessary (it may very well be, but i'm curious)
<span class="quote">> Source/WebCore/editing/VisiblePosition.h:57
> + , m_isBoundary(false)</span >
m_isBoundary should be false by default. you may not need to initialize
<span class="quote">> Source/WebCore/editing/VisiblePosition.h:60
> + VisiblePosition(bool boundary) : m_affinity(VP_DEFAULT_AFFINITY), m_isBoundary(boundary) { };</span >
should this be "bool boundary = false" so you get the default behavior without changing code to be no?
or should we make a static boundaryVisiblePosition() class method that returns the right object
i know people don't generally like passing around bools where the value is not clear what its for
<span class="quote">> LayoutTests/accessibility/mac/selection-boundary-userinfo.html:8
> +<div role="textbox" tabindex=0 id="textbox" contenteditable=true></span >
can you also add a test with a input type="text"
<span class="quote">> LayoutTests/accessibility/mac/selection-boundary-userinfo.html:30
> + shouldBe("results[0]", "AXTextStateChangeTypeSelectionMove");</span >
looks like this file has some tabs in it</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>