<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - WK2: Request completion candidates when needed"
href="https://bugs.webkit.org/show_bug.cgi?id=153040#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - WK2: Request completion candidates when needed"
href="https://bugs.webkit.org/show_bug.cgi?id=153040">bug 153040</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153040#c13">comment #13</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=268909&action=diff" name="attach_268909" title="Patch">attachment 268909</a> <a href="attachment.cgi?id=268909&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=268909&action=review">https://bugs.webkit.org/attachment.cgi?id=268909&action=review</a>
>
> > Source/WebKit2/Shared/EditorState.cpp:131
> > +#if PLATFORM(MAC)
> > + encoder << candidateRequestStartPosition;
> > + encoder << paragraphContextForCandidateRequest;
> > + encoder << stringForCandidateRequest;
> > +#endif
>
> EditorState is a very unfortunate hack which cannot possibly result in
> reliable behavior.
>
> Does the API require synchronous return? Can we request making it
> asynchronous?</span >
I was not aware that EditorState is considered a hack! I'm open to other ideas for the best way to implement this. The API does not require synchronous return, but we do need to request candidates on every selection change, and the analogous iOS API is implemented via EditorState, so it seems like a good place for it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>