<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add QUnit for unit testing and add a unit test to test BuildbotQueueView._appendPendingRevisionCount."
href="https://bugs.webkit.org/show_bug.cgi?id=152910#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add QUnit for unit testing and add a unit test to test BuildbotQueueView._appendPendingRevisionCount."
href="https://bugs.webkit.org/show_bug.cgi?id=152910">bug 152910</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=152910#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=268561&action=diff" name="attach_268561" title="Patch">attachment 268561</a> <a href="attachment.cgi?id=268561&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=268561&action=review">https://bugs.webkit.org/attachment.cgi?id=268561&action=review</a>
>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:2
> > +QUnit.test("BuildBotQueue Test", function( assert )
>
> Please remove the space characters inside the parentheses.</span >
Will do.
<span class="quote">>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:5
> > + assert.ok(trac, "trac is not null");
>
> What is the purpose of this test? I mean, this test is not meaningful given
> that trac is guaranteed to be non-null by definition of the new operator.</span >
Will remove.
<span class="quote">>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:11
> > + name: "Webkit Repo",
>
> Nit: Webkit => WebKit</span >
Will fix.
<span class="quote">>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:15
> > + assert.ok(queue, "queue is not null");
>
> Similarly, this test is not meaningful by the same reason as given in my
> remark for line 5. Moreover, if queue was null then this script would cause
> a JavaScript TypeError when we assign property branches to it on line 8; =>
> we would never execute this line.</span >
Will remove.
<span class="quote">>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:18
> > + assert.ok(view, "view is not null");
>
> Similarly, this is test is not meaningful.</span >
Ditto.
<span class="quote">>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:22
> > + var revisionsBehind = view.element.getElementsByClassName("message")[0].innerHTML.match(/.*(\d+) revision(|s) behind/)[1];
> > + assert.equal(revisionsBehind, 1, "assert revisions behind");
>
> Can you elaborate on how we are one revision behind?</span >
The MockBuildbotQueueView is programmed to return 33020 as the "_latestProductiveIteration" whereas the "latestRecordedRevisionNumber" is 33022 and 33021 is on "someOtherBranch". Therefore, out of all of the known revision numbers on "trunk", there is only one revision, 33022, which is later than the "_latestProductiveIteration".</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>