<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [mips] Add new or32 implementation after r194613"
href="https://bugs.webkit.org/show_bug.cgi?id=152865#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [mips] Add new or32 implementation after r194613"
href="https://bugs.webkit.org/show_bug.cgi?id=152865">bug 152865</a>
from <span class="vcard"><a class="email" href="mailto:jbriance@cisco.com" title="Julien Brianceau <jbriance@cisco.com>"> <span class="fn">Julien Brianceau</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=268495&action=diff" name="attach_268495" title="Patch">attachment 268495</a> <a href="attachment.cgi?id=268495&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=268495&action=review">https://bugs.webkit.org/attachment.cgi?id=268495&action=review</a>
<span class="quote">>> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:384
>> + if (imm.m_value > 0 && imm.m_value < 65535</span >
Please use a or32(TrustedImm32, RegisterID) call here to avoid code duplication, something like this:
load32(dest.m_ptr, immTempRegister);
or32(imm, dest);
store32(immTempRegister, dest.m_ptr);
<span class="quote">> I'm no mips expert, but should this be <= 65535? There are other places in MacroAssemblerMIPS.h where this is also < 65535, but don't they all work using the 16-bit immediate value if the immediate value is equal to 65535, too?</span >
You're right Alex, I also think this should be <= 0xffff. As there are other places in MacroAssemblerMIPS needing this change, maybe we could do this in a separate change ?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>