<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Cleanup RenderThemeGtk"
href="https://bugs.webkit.org/show_bug.cgi?id=152888">bug 152888</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #268539 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Cleanup RenderThemeGtk"
href="https://bugs.webkit.org/show_bug.cgi?id=152888#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Cleanup RenderThemeGtk"
href="https://bugs.webkit.org/show_bug.cgi?id=152888">bug 152888</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=268539&action=diff" name="attach_268539" title="Patch">attachment 268539</a> <a href="attachment.cgi?id=268539&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=268539&action=review">https://bugs.webkit.org/attachment.cgi?id=268539&action=review</a>
Excellent patch; this worked quite well. Thanks for taking the time to work on this. Please watch the bots when this lands.
Looks like this also fixes <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Non-symbolic icons used for edit-find and edit-clear"
href="show_bug.cgi?id=151502">bug #151502</a>. Please close that when this lands.
Somewhat related: look at <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Gradient on large text fields"
href="show_bug.cgi?id=152273">bug #152273</a>.
<span class="quote">> Source/WebCore/rendering/RenderThemeGtk.cpp:140
> +enum RenderThemePart {</span >
I prefer to almost always use enum class in new code, both for safety, and also because I think it's more readable to use the RenderThemePart:: scope everywhere. But if you prefer to avoid the scoping, this is fine.
<span class="quote">> Source/WebCore/rendering/RenderThemeGtk.cpp:379
> + gtk_style_context_set_state(context.get(), gtk_widget_path_iter_get_state(path.get(), -1));</span >
What's this for? Looks like a mistake. You have not set any state on the GtkWidgetPath. If this code actually does anything, then I would suspect that context might be inheriting its state from its parent... in which case it would be clearer to pass GTK_STATE_FLAGS_NONE.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>