<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Cleanup ScrollbarThemeGtk"
href="https://bugs.webkit.org/show_bug.cgi?id=152830">bug 152830</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>mcatanzaro@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Cleanup ScrollbarThemeGtk"
href="https://bugs.webkit.org/show_bug.cgi?id=152830#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Cleanup ScrollbarThemeGtk"
href="https://bugs.webkit.org/show_bug.cgi?id=152830">bug 152830</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=152830#c4">comment #4</a>)
<span class="quote">> You can ask any question without rejecting the patch.</span >
I really was rejecting this version of the patch. ;) Because...
<span class="quote">> The ScrollbarTheme methods are called either to get layout information
> (mainly scrollbarThickness) or to actually paint. Paint is the one calling
> all others (paintScrollbarBackground, paintTrackBackground, paintThumb,
> etc.). What I'm doing is caching the parent style context only for the
> paint() scope, to avoid creating new style contexts from any other method
> called from paint(). The style properties we cache are all properties of the
> parent scrollbar class.</span >
...I did not understand that this cache existed only for the scope of paint(). This invalidates all of my concerns.
<span class="quote">> No, GtkScrollbar inherits from GtkRange that implements GtkOrientable. See
> _gtk_orientable_set_style_classes(). There's indeed some specific CSS
> depending on the orientation for scrollbars in Adwaita, see:</span >
Hm, a documentation issue then; the documentation for other widgets mentions this clearly.
<span class="quote">> I had a previous version where I passed a state, this looks like a leftover.</span >
OK. This is the only thing that needs fixed.
<span class="quote">> This is the first call. Note that all other methods calling
> getOrCreateStyleContext() are not caching it, only paint is caching this
> context.</span >
OK, I understand now.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>