<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Prefer GTK implementation over native Windows"
href="https://bugs.webkit.org/show_bug.cgi?id=137974">bug 137974</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #240284 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Prefer GTK implementation over native Windows"
href="https://bugs.webkit.org/show_bug.cgi?id=137974#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Prefer GTK implementation over native Windows"
href="https://bugs.webkit.org/show_bug.cgi?id=137974">bug 137974</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=240284&action=diff" name="attach_240284" title="proposed wk patch">attachment 240284</a> <a href="attachment.cgi?id=240284&action=edit" title="proposed wk patch">[details]</a></span>
proposed wk patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=240284&action=review">https://bugs.webkit.org/attachment.cgi?id=240284&action=review</a>
Milan, sorry for the late review. I'm going to r- this simply because the GTK port does not have any support for Windows anymore. If that situation ever changes (if you or someone else ever gets it working), then of course it would make sense to reconsider this patch.
<span class="quote">> Source/WTF/wtf/Compiler.h:97
> +#define WTF_COMPILER_GCC 1</span >
I don't think this is right; a quick Google search tells me that MinGW supports Clang. Even though clang pretends to be GCC, we don't want COMPILER(GCC) to return true unless the compiler really is GCC.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>