<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] JSC shell sources should include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES"
href="https://bugs.webkit.org/show_bug.cgi?id=152664#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] JSC shell sources should include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES"
href="https://bugs.webkit.org/show_bug.cgi?id=152664">bug 152664</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=152664#c7">comment #7</a>)
<span class="quote">> Shouldn't JavaScriptCore_INCLUDE_DIRECTORIES be removed from
> PlatformWin.cmake instead?</span >
No, it's needed because in PlatformWin.cmake we make jscLib, which isn't needed in non-windows ports. jsc.exe is just a simple program that finds jscLib and starts it after possibly finding some other dlls.
I don't think it's critical to include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES on Windows. It wouldn't hurt, but I don't think it's needed. Commit this adding it to Windows or not, but don't remove JavaScriptCore_INCLUDE_DIRECTORIES from PlatformWin.cmake.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>