<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] JSC shell sources should include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES"
href="https://bugs.webkit.org/show_bug.cgi?id=152664#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] JSC shell sources should include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES"
href="https://bugs.webkit.org/show_bug.cgi?id=152664">bug 152664</a>
from <span class="vcard"><a class="email" href="mailto:annulen@yandex.ru" title="Konstantin Tokarev <annulen@yandex.ru>"> <span class="fn">Konstantin Tokarev</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=152664#c6">comment #6</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=152664#c5">comment #5</a>)
> > (In reply to <a href="show_bug.cgi?id=152664#c3">comment #3</a>)
> > > Comment on <span class=""><a href="attachment.cgi?id=268140&action=diff" name="attach_268140" title="Added include_directories(JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES)">attachment 268140</a> <a href="attachment.cgi?id=268140&action=edit" title="Added include_directories(JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES)">[details]</a></span>
> > > Added include_directories(JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES)
> > >
> > > Sorry for breaking this!
> > >
> > > I am going to give cq- since this same construct exists in PlatformWin.cmake
> > > in this directory. Please fix it there too!
> >
> > I'm not building for Windows, but for me it seems like it includes
> > ${JavaScriptCore_INCLUDE_DIRECTORIES} twice, first time in CMakeLists.txt
> > and second time in PlatformWin.cmake. Other port don't do it
>
> yes, we meant it needs to be fixed in this patch together.</span >
Shouldn't JavaScriptCore_INCLUDE_DIRECTORIES be removed from PlatformWin.cmake instead?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>