<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Too easy to add contributors to wrong place in contributors.json"
href="https://bugs.webkit.org/show_bug.cgi?id=152665">152665</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Too easy to add contributors to wrong place in contributors.json
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>Other
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Minor
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Tools / Tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>mcatanzaro@igalia.com
</td>
</tr>
<tr>
<th>CC</th>
<td>lforschler@apple.com
</td>
</tr></table>
<p>
<div>
<pre>contributors.json has three lists: committers, contributors (who are neither committers nor reviewers; good to make it easy to CC people or bots in Bugzilla), and reviewers. But the file is very long, so it's easy to not realize this and add a name to the wrong list, or get confused about which part of the file you are in.
For instance, it took three tries to get Sebastian's name in the right place:
<a href="http://trac.webkit.org/changeset/190959">http://trac.webkit.org/changeset/190959</a>
<a href="http://trac.webkit.org/changeset/194432">http://trac.webkit.org/changeset/194432</a>
<a href="http://trac.webkit.org/changeset/194511">http://trac.webkit.org/changeset/194511</a>
I also noticed Frédéric was in the wrong place:
<a href="http://trac.webkit.org/changeset/194512">http://trac.webkit.org/changeset/194512</a>
I only caught these two cases because these are folks whom I happen to know, and I was looking through the file while moving myself to the reviewers list. There are probably many other contributors in the wrong place.
Make it more difficult to add people in the wrong place by splitting these lists out into three separate files.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>