<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Minibrowser: On opening search bar, search for selected text if any"
href="https://bugs.webkit.org/show_bug.cgi?id=128459">bug 128459</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #223572 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Minibrowser: On opening search bar, search for selected text if any"
href="https://bugs.webkit.org/show_bug.cgi?id=128459#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Minibrowser: On opening search bar, search for selected text if any"
href="https://bugs.webkit.org/show_bug.cgi?id=128459">bug 128459</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=223572&action=diff" name="attach_223572" title="Patch">attachment 223572</a> <a href="attachment.cgi?id=223572&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=223572&action=review">https://bugs.webkit.org/attachment.cgi?id=223572&action=review</a>
Thanks for the review, Berto. Updating the flags to make it official and remove this from request queue....
<span class="quote">> Tools/MiniBrowser/gtk/BrowserSearchBar.c:322
> + g_free(selectedText);</span >
Surely you need to free selectedText even if it's zero-length, since you allocated the memory.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>