<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [INTL] Implement Intl.NumberFormat.prototype.resolvedOptions ()"
href="https://bugs.webkit.org/show_bug.cgi?id=147602">bug 147602</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #267624 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [INTL] Implement Intl.NumberFormat.prototype.resolvedOptions ()"
href="https://bugs.webkit.org/show_bug.cgi?id=147602#c18">Comment # 18</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [INTL] Implement Intl.NumberFormat.prototype.resolvedOptions ()"
href="https://bugs.webkit.org/show_bug.cgi?id=147602">bug 147602</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=267624&action=diff" name="attach_267624" title="Patch">attachment 267624</a> <a href="attachment.cgi?id=267624&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=267624&action=review">https://bugs.webkit.org/attachment.cgi?id=267624&action=review</a>
<span class="quote">> Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:92
> + Vector<String> keyLocaleData({</span >
Seems unfortunate to re-create this vector every time the function is called. Might consider changing the function’s interface to return a const& unless it can involve computing a unique value and using a static NeverDestroyed for this particular case.
<span class="quote">> Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:158
> + for (const auto& currencyMinorUnit : currencyMinorUnits) {</span >
This list might be long enough that's binary search would be faster than a linear one.
<span class="quote">> Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:159
> + if (currency == currencyMinorUnit.first)</span >
Is it correct that this is a case sensitive check?
<span class="quote">> Source/JavaScriptCore/runtime/IntlObject.cpp:239
> + if (std::isnan(doubleValue) || doubleValue < static_cast<double>(minimum) || doubleValue > static_cast<double>(maximum)) {</span >
There is a way to write this without an explicit check for NaN.
If (!(x >= min && x <= max))
<span class="quote">> Source/JavaScriptCore/runtime/IntlObject.cpp:245
> + return static_cast<unsigned>(doubleValue);</span >
This has peculiar behavior for max + 0.1; do we have test cases that cover values just slightly under min and slightly over max?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>