<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Cache redirects as separate entries"
href="https://bugs.webkit.org/show_bug.cgi?id=152424">bug 152424</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #267630 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Cache redirects as separate entries"
href="https://bugs.webkit.org/show_bug.cgi?id=152424#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Cache redirects as separate entries"
href="https://bugs.webkit.org/show_bug.cgi?id=152424">bug 152424</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=267630&action=diff" name="attach_267630" title="patch">attachment 267630</a> <a href="attachment.cgi?id=267630&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=267630&action=review">https://bugs.webkit.org/attachment.cgi?id=267630&action=review</a>
r=me one these questions are addressed.
<span class="quote">> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:185
> - if (NetworkCache::singleton().isEnabled())
> + if (canUseCache(request))</span >
Did you change all uses of NetworkCache::singleton().isEnabled to canUseCache? This seems like a very important change that we should've done long ago.
<span class="quote">> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:-336
> - // Make sure we don't keep a stale entry in the cache.</span >
Why don't we need to remove any cache entries here any more?
<span class="quote">> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:402
> +#if ENABLE(NETWORK_CACHE)</span >
You might need an #else UNUSED_PARAM(request);
And maybe it should be called something like originalRequest.
<span class="quote">> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:531
> +void NetworkResourceLoader::dispatchWillSendRequestForCacheEntry(std::unique_ptr<NetworkCache::Entry> entry)</span >
This is only called from one place and might not need its own function unless you plan to use it from other places in the future.
<span class="quote">> LayoutTests/http/tests/cache/disk-cache/disk-cache-redirect-expected.txt:10
> +response source: Disk cache</span >
How is the first response from the Disk cache?
<span class="quote">> LayoutTests/http/tests/cache/disk-cache/disk-cache-redirect.html:17
> + { responseHeaders: {'Cache-control': 'max-age=0' } },
> + { responseHeaders: {'Cache-control': 'max-age=100' } },</span >
If I'm correct, the first cache entry expires immediately, and the second cache entry does not expire immediately, so we test making a request for a cache entry that has expired. Why don't we make another request after the second one to test making a request for a cache entry that has not expired?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>