<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Make WebInspector.ConsoleMessageView faster"
href="https://bugs.webkit.org/show_bug.cgi?id=152418#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Make WebInspector.ConsoleMessageView faster"
href="https://bugs.webkit.org/show_bug.cgi?id=152418">bug 152418</a>
from <span class="vcard"><a class="email" href="mailto:nvasilyev@apple.com" title="Nikita Vasilyev <nvasilyev@apple.com>"> <span class="fn">Nikita Vasilyev</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=152418#c1">comment #1</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=152418#c0">comment #0</a>)
> > Created <span class=""><a href="attachment.cgi?id=267609" name="attach_267609" title="[Image] Stacktrace in Timelines">attachment 267609</a> <a href="attachment.cgi?id=267609&action=edit" title="[Image] Stacktrace in Timelines">[details]</a></span>
> > [Image] Stacktrace in Timelines
>
> This timeline recording shows that _appendLocationLink takes 23.13ms
> out of 23.43ms of ConsoleMessageView execution time. That's 98.7%!
> 98.7% of ConsoleMessageView execution time spent on adding the source link.
>
> I don't understand what happens in addEventListener selected on the image.
> Timelines doesn't tell me why *adding* an event listener takes so long.</span >
Our addEventListener is O(n).
for (var i = 0; i < listeners.length; ++i) {
if (listeners[i].listener === listener && listeners[i].thisObject === thisObject)
return;
}
Put it in a loop and it's O(n^2)!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>