<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [INTL] Implement Intl.NumberFormat.prototype.resolvedOptions ()"
href="https://bugs.webkit.org/show_bug.cgi?id=147602#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [INTL] Implement Intl.NumberFormat.prototype.resolvedOptions ()"
href="https://bugs.webkit.org/show_bug.cgi?id=147602">bug 147602</a>
from <span class="vcard"><a class="email" href="mailto:sukolsak@gmail.com" title="Sukolsak Sakshuwong <sukolsak@gmail.com>"> <span class="fn">Sukolsak Sakshuwong</span></a>
</span></b>
<pre>I've made several changes to this patch to bring it into line with the Intl.Collator patch (<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [INTL] Implement Collator Compare Functions"
href="show_bug.cgi?id=147604">Bug 147604</a>).
(In reply to <a href="show_bug.cgi?id=147602#c10">comment #10</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=264455&action=diff" name="attach_264455" title="Patch">attachment 264455</a> <a href="attachment.cgi?id=264455&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=264455&action=review">https://bugs.webkit.org/attachment.cgi?id=264455&action=review</a>
>
> r=me
>
> > Source/JavaScriptCore/runtime/IntlNumberFormat.h:87
> > + unsigned m_minimumIntegerDigits;
> > + unsigned m_minimumFractionDigits;
> > + unsigned m_maximumFractionDigits;
>
> These need initializers.
>
> > Source/JavaScriptCore/runtime/IntlNumberFormat.h:91
> > + bool m_useGrouping;
>
> And this.</span >
Done.
<span class="quote">> > Source/JavaScriptCore/runtime/IntlNumberFormatConstructor.cpp:71
> > +#ifndef NDEBUG
> > + ASSERT(key == "nu");
> > +#else
> > + UNUSED_PARAM(key);
> > +#endif
>
> You can use ASSERT_UNUSED here instead.</span >
Done.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>