<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Teach dashboard code to compare non-integer revisions."
href="https://bugs.webkit.org/show_bug.cgi?id=152345#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Teach dashboard code to compare non-integer revisions."
href="https://bugs.webkit.org/show_bug.cgi?id=152345">bug 152345</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=152345#c2">comment #2</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=267470&action=diff" name="attach_267470" title="Patch">attachment 267470</a> <a href="attachment.cgi?id=267470&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=267470&action=review">https://bugs.webkit.org/attachment.cgi?id=267470&action=review</a>
>
> I didn't review this at all, just opened at a random place and couldn't help
> but post a couple comments.
>
> It's great to have tests!
>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:5
> > + <meta charset="UTF-8" />
> > + <meta http-equiv="content-type" content="text/html; charset=utf-8" />
>
> The first line is sufficient. Also, please don't use XML auto-closing syntax
> in HTML, it's invalid there.</span >
Thanks, I addressed these issues.
<span class="quote">>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:9
> > + <link rel="stylesheet" href="<a href="https://code.jquery.com/qunit/qunit-1.20.0.css">https://code.jquery.com/qunit/qunit-1.20.0.css</a>">
>
> We try to make our tests not access external resources. There are already
> parts of jquery in External directory for the dashboard.</span >
Thanks for clarifying. I wasn't sure if I was supposed to add external code, but it sounds like we have a specific place just for doing that. I put the CSS file in there too. Should it go in External or Styles? Also, check-webkit-style did not like all of the tabs present in QUnit:
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/qunit-1.20.0.css:300: Line contains tab character. [whitespace/tab] [5]
Is that an issue?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>