<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Builtin source should be minified more"
href="https://bugs.webkit.org/show_bug.cgi?id=152290">bug 152290</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>webkit-unassigned@lists.webkit.org
</td>
<td>joepeck@webkit.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Builtin source should be minified more"
href="https://bugs.webkit.org/show_bug.cgi?id=152290#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Builtin source should be minified more"
href="https://bugs.webkit.org/show_bug.cgi?id=152290">bug 152290</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>I'll handle some basic stuff, like stripping the empty comments and empty lines. I think it leads to even more readable code in the results anyways:
BEFORE:
<span class="quote">> const int s_moduleLoaderObjectRequestFetchCodeLength = 669;
> const char* s_moduleLoaderObjectRequestFetchCode =
> "(function (key)\n" \
> "{\n" \
> " //\n" \
> "\n" \
> " \"use strict\";\n" \
> "\n" \
> " var entry = this.ensureRegistered(key);\n" \
> " if (entry.state > this.Link) {\n" \
> " var deferred = @newPromiseCapability(@InternalPromise);\n" \
> " deferred.@reject.@call(undefined, new @TypeError(\"Requested module is already ready to be executed.\"));\n" \
> " return deferred.@promise;\n" \
> " }\n" \
> "\n" \
> " if (entry.fetch)\n" \
> " return entry.fetch;\n" \
> "\n" \
> " var loader = this;\n" \
> "\n" \
> " //\n" \
> " //\n" \
> " //\n" \
> " //\n" \
> " //\n" \
> " //\n" \
> " var fetchPromise = this.fetch(key).then(function (payload) {\n" \
> " loader.setStateToMax(entry, loader.Translate);\n" \
> " return payload;\n" \
> " });\n" \
> " entry.fetch = fetchPromise;\n" \
> " return fetchPromise;\n" \
> "})\n" \
> ;</span >
AFTER:
<span class="quote">> const int s_moduleLoaderObjectRequestFetchCodeLength = 615;
> const char* s_moduleLoaderObjectRequestFetchCode =
> "(function (key)\n" \
> "{\n" \
> " \"use strict\";\n" \
> " var entry = this.ensureRegistered(key);\n" \
> " if (entry.state > this.Link) {\n" \
> " var deferred = @newPromiseCapability(@InternalPromise);\n" \
> " deferred.@reject.@call(undefined, new @TypeError(\"Requested module is already ready to be executed.\"));\n" \
> " return deferred.@promise;\n" \
> " }\n" \
> " if (entry.fetch)\n" \
> " return entry.fetch;\n" \
> " var loader = this;\n" \
> " var fetchPromise = this.fetch(key).then(function (payload) {\n" \
> " loader.setStateToMax(entry, loader.Translate);\n" \
> " return payload;\n" \
> " });\n" \
> " entry.fetch = fetchPromise;\n" \
> " return fetchPromise;\n" \
> "})\n" \
> ;</span >
I didn't go all out and minify everything though. I think this is a good balance.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>