<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactoring HTMLMediaElement getStartDate() implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=152181#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactoring HTMLMediaElement getStartDate() implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=152181">bug 152181</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=267179&action=diff" name="attach_267179" title="Just checking if this change may not break other tests">attachment 267179</a> <a href="attachment.cgi?id=267179&action=edit" title="Just checking if this change may not break other tests">[details]</a></span>
Just checking if this change may not break other tests
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=267179&action=review">https://bugs.webkit.org/attachment.cgi?id=267179&action=review</a>
This patch should only contain the change to HTMLMediaElement.idl. Deleting all the unneeded code can be done in a follow-up that does not change behavior.
<span class="quote">> Source/WebCore/bindings/js/JSDOMBinding.cpp:124
> JSValue jsDateOrNull(ExecState* exec, double value)
> {
> - if (!std::isfinite(value))
> + if (std::isinf(value))
> return jsNull();
> + if (std::isnan(value))
> + return DateInstance::create(exec, exec->lexicalGlobalObject()->dateStructure());
> return DateInstance::create(exec->vm(), exec->lexicalGlobalObject()->dateStructure(), value);
> }</span >
This changes the behavior for every callers of jsDateOrNull when the value is a NaN. We do not want to make that global change.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>