<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - "Illegal instruction" crash on AMD Geode CPU"
href="https://bugs.webkit.org/show_bug.cgi?id=119190#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - "Illegal instruction" crash on AMD Geode CPU"
href="https://bugs.webkit.org/show_bug.cgi?id=119190">bug 119190</a>
from <span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=266982&action=diff" name="attach_266982" title="Disable the JIT on x86 if there's no SSE2">attachment 266982</a> <a href="attachment.cgi?id=266982&action=edit" title="Disable the JIT on x86 if there's no SSE2">[details]</a></span>
Disable the JIT on x86 if there's no SSE2
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=266982&action=review">https://bugs.webkit.org/attachment.cgi?id=266982&action=review</a>
<span class="quote">> Source/JavaScriptCore/runtime/VM.cpp:140
> +#if CPU(X86)
> + if (!MacroAssembler::supportsFloatingPoint())
> + return false;
> +#endif</span >
I don't think if we should disable JIT here with disabling assembler if !supportsFloatingPoint().
( Additionally supportsFloatingPoint() == isSSE2Present() on X86, it would be better to use isSSE2Present(). )
Of course it can be a good workaround to disable JIT until somebody trace down which
SSE2 instruction is emitted and where. The proper fix would be to make JIT not to
emit SSE2 instructions if !isSSE2Present().
There are many ASSERT(isSSE2Present()) assertions in MacroAssermblerX86(Common).h files.
I think one of them should hit in debug mode.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>