<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Crashes on PPC64 due to mprotect() on address not aligned to the page size"
href="https://bugs.webkit.org/show_bug.cgi?id=130237#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Crashes on PPC64 due to mprotect() on address not aligned to the page size"
href="https://bugs.webkit.org/show_bug.cgi?id=130237">bug 130237</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=266803&action=diff" name="attach_266803" title="Make commitSize at least as big as the page size (v2)">attachment 266803</a> <a href="attachment.cgi?id=266803&action=edit" title="Make commitSize at least as big as the page size (v2)">[details]</a></span>
Make commitSize at least as big as the page size (v2)
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=266803&action=review">https://bugs.webkit.org/attachment.cgi?id=266803&action=review</a>
<span class="quote">> Source/JavaScriptCore/interpreter/JSStack.cpp:48
> + static size_t size = 0;
> + if (!size)
> + size = std::max(16 * 1024, getpagesize());
> + return size;</span >
The check for 0 here is unneeded and unhelpful. This should just be:
static size_t size = std::max<size_t>(16 * 1024, pageSize());
return size;</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>