<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [GTK] Allow to save and restore session"
href="https://bugs.webkit.org/show_bug.cgi?id=115600#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [GTK] Allow to save and restore session"
href="https://bugs.webkit.org/show_bug.cgi?id=115600">bug 115600</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=115600#c9">comment #9</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=115600#c8">comment #8</a>)
> > (In reply to <a href="show_bug.cgi?id=115600#c7">comment #7</a>)
> > > Comment on <span class=""><a href="attachment.cgi?id=266798&action=diff" name="attach_266798" title="Patch">attachment 266798</a> <a href="attachment.cgi?id=266798&action=edit" title="Patch">[details]</a></span>
> > > Patch
> > >
> > > View in context:
> > > <a href="https://bugs.webkit.org/attachment.cgi?id=266798&action=review">https://bugs.webkit.org/attachment.cgi?id=266798&action=review</a>
> > >
> > > > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewSessionState.cpp:136
> > > > + g_return_val_if_fail(state, nullptr);
> > > > + IPC::ArgumentEncoder encoder;
> > > > + encoder << state->sessionState.backForwardListState;
> > > > + encoder << state->sessionState.renderTreeSize;
> > > > + encoder << state->sessionState.provisionalURL;
> > > > + return g_bytes_new(encoder.buffer(), encoder.bufferSize());
> > >
> > > NO.
> > >
> > > Don't do this, we DON'T want to rely on the IPC encoding for this.
> >
> > Ok, I simply didn't know it. What's the right way then? Should I use my own
> > encoding/decoding thing?
>
> Yes. Preferably something that can be extended without breaking the format.
>
> FWIW, the reason we don't want this is because it means we can't change the
> IPC format without breaking compat. We did this on OS X in the past and it
> caused us lots of pain.</span >
Ok, understood, thanks for the explanation. I'll rework it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>