<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Use multiple iOS simulator instead of multiple apps on single simulator for running layout-tests"
href="https://bugs.webkit.org/show_bug.cgi?id=151243">bug 151243</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #266839 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use multiple iOS simulator instead of multiple apps on single simulator for running layout-tests"
href="https://bugs.webkit.org/show_bug.cgi?id=151243#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use multiple iOS simulator instead of multiple apps on single simulator for running layout-tests"
href="https://bugs.webkit.org/show_bug.cgi?id=151243">bug 151243</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=266839&action=diff" name="attach_266839" title="Updated patch with review comments incorporated.">attachment 266839</a> <a href="attachment.cgi?id=266839&action=edit" title="Updated patch with review comments incorporated.">[details]</a></span>
Updated patch with review comments incorporated.
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=266839&action=review">https://bugs.webkit.org/attachment.cgi?id=266839&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:132
> + def num_child_processes(self):</span >
Please rename to just "child_processes" or "child_processes_option", as it's the same thing as the one in options.
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:143
> + # FIXME: We should also take into account the Add logic to take into account the available RAM.</span >
Please fix the grammar, looks like two variants of the comment collided.
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:148
> + _log.warn("This machine could support %s child processes, but only has enough process limit for %s."
> + % (best_child_process_count_for_cpu, maximum_simulator_count_on_this_system))
> + _log.info('Run "launchctl limit" to check these limits')</span >
Is there a reason to use different log levels here? These look like parts of the same message.
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:280
> + # FIXME: This creates the devices sequentially, this can be optimized.</span >
I think that this can be more specific: "This creates the devices sequentially, doing this in parallel can improve performance".
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:284
> + # FIXME: this is very slow, especially for mulitple simulators, we probably do not need</span >
Please start the sentence with an upper case letter ("This").</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>