<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Use multiple iOS simulator instead of multiple apps on single simulator for running layout-tests"
href="https://bugs.webkit.org/show_bug.cgi?id=151243">bug 151243</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #266808 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use multiple iOS simulator instead of multiple apps on single simulator for running layout-tests"
href="https://bugs.webkit.org/show_bug.cgi?id=151243#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use multiple iOS simulator instead of multiple apps on single simulator for running layout-tests"
href="https://bugs.webkit.org/show_bug.cgi?id=151243">bug 151243</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=266808&action=diff" name="attach_266808" title="Updated patch">attachment 266808</a> <a href="attachment.cgi?id=266808&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=266808&action=review">https://bugs.webkit.org/attachment.cgi?id=266808&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:78
> + num_workers = None</span >
Do we need this despite default_child_processes being memoized?
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:135
> + num_cpu_cores = self._executive.cpu_count() / 2</span >
For consistency, this should have "count" in the name. From the way it's used, I suggest a name like "best_child_process_count_for_cpu".
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:139
> + maximum_simulator_count_on_this_system = (system_process_count_limit - current_process_count) // self.PROCESS_COUNT_ESTIMATE_PER_SIMULATOR_INSTANCE</span >
Please add a FIXME about checking the amount of RAM.
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:142
> + _log.info('Please increase the process and file limit to launch more Simulators')</span >
Where do we check the file limit?
Also, let's at least log the same info that Mac does:
_log.warning("This machine could support %s child processes, but only has enough memory for %s." % (default_count, supportable_instances))
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:144
> + # FIXME: add url for webpage explaining how to increase these limits</span >
WebKit style is to start FIXME with an upper case letter, and end with a period (i.e. to have a complete sentence).
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:226
> + if (int(self.host.platform._platform_module.mac_ver()[0].strip().replace("10.", "")) < 12):</span >
I suggest comparing to "10.10" and "10.11" instead - that way it will be easier to find and delete in the future.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>