<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r192247): [GTK] ASSERTION FAILED: type == WebCore::ActionType || type == WebCore::CheckableActionType || type == WebCore::SeparatorType"
href="https://bugs.webkit.org/show_bug.cgi?id=151513#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r192247): [GTK] ASSERTION FAILED: type == WebCore::ActionType || type == WebCore::CheckableActionType || type == WebCore::SeparatorType"
href="https://bugs.webkit.org/show_bug.cgi?id=151513">bug 151513</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=266243&action=diff" name="attach_266243" title="Patch">attachment 266243</a> <a href="attachment.cgi?id=266243&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=266243&action=review">https://bugs.webkit.org/attachment.cgi?id=266243&action=review</a>
<span class="quote">>> Source/WebKit2/Shared/gtk/WebContextMenuItemGtk.cpp:128
>> + : WebContextMenuItemData(data.type() == SubmenuType ? ActionType : data.type(), data.action(), data.title(), data.enabled(), data.checked())
>
> I think you should add this check to the constructor above, as well...</span >
I don't think so, the constructor above receives a type, the caller should provide the right type. We internally don't use the submenu type,l so we only need to check it when constructing from an external source like WebContextMenuItemData, but not from our own implementation
<span class="quote">>> Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuItem.cpp:212
>> + item->priv->menuItem = std::make_unique<WebContextMenuItemGtk>(ActionType, ContextMenuItemBaseApplicationTag, String::fromUTF8(label));
>
> ...so that you don't need to do this.</span >
I prefer to make this explicit. This is building a WebContextMenuItemGtk, which doesn't use SubmenuType.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>