<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Selection.deleteFromDocument should not leave a selection character"
href="https://bugs.webkit.org/show_bug.cgi?id=151442#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Selection.deleteFromDocument should not leave a selection character"
href="https://bugs.webkit.org/show_bug.cgi?id=151442">bug 151442</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151442#c11">comment #11</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=151442#c10">comment #10</a>)
> > (In reply to <a href="show_bug.cgi?id=151442#c9">comment #9</a>)
> > > Note that this doesn't introduce a crash, but a test that reveals an
> > > existing crash. The new test crashes in debug build even without the changes
> > > introduced in this patch.
> >
> > Still seems that we should fix that bug before making this behavior change,
> > though. Should not be a challenging project and there is no hurry to change
> > this behavior since we have had it for a long time.
>
> This behavior has always been there, but we didn't know it caused a crash (a
> real one, not an assert, so it happens in release as well) until
> editing/selection/deleteFromDocument-crash.html was imported from blink.
> That test crashes for all ports not using the mac editing behavior. This
> patch also adds editing/selection/deleteFromDocument-undo-crash.html, but
> because it's a blink merge and the test was part of the commit. So, what I
> can do, is fixing this real crash for the existing test, and add the new
> test as part of the <a class="bz_bug_link
bz_status_NEW "
title="NEW - ASSERTION FAILED: m_offset <= m_node->length() in DeleteFromTextNodeCommand::DeleteFromTextNodeCommand"
href="show_bug.cgi?id=151488">bug #151488</a> with the patch to fix it.</span >
I'm wrong, I think I was confusing this with other test, this is just a failure, not a crash.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>