<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment"
href="https://bugs.webkit.org/show_bug.cgi?id=149338">bug 149338</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #266216 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment"
href="https://bugs.webkit.org/show_bug.cgi?id=149338#c131">Comment # 131</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment"
href="https://bugs.webkit.org/show_bug.cgi?id=149338">bug 149338</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=266216&action=diff" name="attach_266216" title="Patch">attachment 266216</a> <a href="attachment.cgi?id=266216&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=266216&action=review">https://bugs.webkit.org/attachment.cgi?id=266216&action=review</a>
<span class="quote">> Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:132
> + UnlinkedFunctionExecutable(VM*, Structure*, const SourceCode&, RefPtr<SourceProvider>&& sourceOverride, FunctionMetadataNode*, UnlinkedFunctionKind, ConstructAbility, VariableEnvironment&, bool);</span >
Style: Can we name this bool in a follow up patch.
<span class="quote">> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2590
> + instructions().append(0);</span >
Lets remove this argument in a follow up patch
<span class="quote">> Source/JavaScriptCore/runtime/Executable.h:463
> + EvalExecutable(ExecState*, const SourceCode&, bool, bool, bool);</span >
style: Lets name these bools in a follow up patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>