<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win] Implement methods to get and set inner html."
href="https://bugs.webkit.org/show_bug.cgi?id=151569">bug 151569</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #266093 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win] Implement methods to get and set inner html."
href="https://bugs.webkit.org/show_bug.cgi?id=151569#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win] Implement methods to get and set inner html."
href="https://bugs.webkit.org/show_bug.cgi?id=151569">bug 151569</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=266093&action=diff" name="attach_266093" title="Patch">attachment 266093</a> <a href="attachment.cgi?id=266093&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=266093&action=review">https://bugs.webkit.org/attachment.cgi?id=266093&action=review</a>
This looks a lot like the innerText implementation just below it :)
r=me, mac test failures unrelated.
<span class="quote">> Source/WebKit/win/DOMHTMLClasses.cpp:507
> + String innerHtmlString = downcast<HTMLElement>(m_element)->innerHTML();</span >
innerHTMLString
<span class="quote">> Source/WebKit/win/DOMHTMLClasses.cpp:515
> + HTMLElement* htmlElement = downcast<HTMLElement>(m_element);</span >
Why don't you also rename setInnerText's htmlEle to htmlElement while you're at it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>