<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] ImageDiff should normalize the diff image"
href="https://bugs.webkit.org/show_bug.cgi?id=151261#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] ImageDiff should normalize the diff image"
href="https://bugs.webkit.org/show_bug.cgi?id=151261">bug 151261</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151261#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=265855&action=diff" name="attach_265855" title="Patch">attachment 265855</a> <a href="attachment.cgi?id=265855&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=265855&action=review">https://bugs.webkit.org/attachment.cgi?id=265855&action=review</a>
>
> Can't we immediately unskip a bunch of tests?</span >
No, this doesn't fix any test, this only makes it easier to see the differences when they are minimum, see the examples Carlos posted here, without the patch you see a diff that looks completely black, while after the patch you easily see the pixel that is different.
<span class="quote">> > Tools/ImageDiff/gtk/ImageDiff.cpp:85
> > + bufferPixel /= maxDistance;
>
> What guarantees that maxDistance is not 0?</span >
I think differenceImageFromDifferenceBuffer wouldn't be called in that case, I could ensure it just in case</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>